[core] Speed up test_runtime_env_conda_and_pip_3.py
#52997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Oakes <[email protected]>
edoakes
force-pushed
the
eoakes/speed-up-re-3
branch
from
a7aa122 to
a38161c
Compare
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
dayshah
approved these changes
May 14, 2025
…es/speed-up-re-3
iamjustinhsu
pushed a commit
to iamjustinhsu/ray
that referenced
this pull request
May 15, 2025
) This test takes >300s in CI. Speeding it up by: - Removing parametrization for file vs. python_object (doesn't have any affect on GC behavior). - Combining conda and pip conditions in the tests. This should reduce the runtime by more than 2x. Not using a shared cluster fixture because we need to set the system config differently with the way the tests are written. --------- Signed-off-by: Edward Oakes <[email protected]> Signed-off-by: iamjustinhsu <[email protected]>
lk-chen
pushed a commit
to lk-chen/ray
that referenced
this pull request
May 17, 2025
) This test takes >300s in CI. Speeding it up by: - Removing parametrization for file vs. python_object (doesn't have any affect on GC behavior). - Combining conda and pip conditions in the tests. This should reduce the runtime by more than 2x. Not using a shared cluster fixture because we need to set the system config differently with the way the tests are written. --------- Signed-off-by: Edward Oakes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test takes >300s in CI.
Speeding it up by:
This should reduce the runtime by more than 2x.
Not using a shared cluster fixture because we need to set the system config differently with the way the tests are written.