[RLlib; Offline RL] Fix worker_index in 'OfflineEvaluationRunner' and 'Runner'.
#53000
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: simonsays1980 <[email protected]>
Signed-off-by: simonsays1980 <[email protected]>
sven1977
changed the title
worker_index in 'OfflineEvaluationRunner' and 'Runner'.worker_index in 'OfflineEvaluationRunner' and 'Runner'.
kenmcheng
pushed a commit
to kenmcheng/ray
that referenced
this pull request
May 27, 2025
lk-chen
pushed a commit
to lk-chen/ray
that referenced
this pull request
May 28, 2025
chris-ray-zhang
pushed a commit
to chris-ray-zhang/ray
that referenced
this pull request
May 29, 2025
…nd 'Runner'. (ray-project#53000) Signed-off-by: Chris Zhang <[email protected]>
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jun 3, 2025
…nd 'Runner'. (ray-project#53000) Signed-off-by: Vicky Tsang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is a small fix with a large impact and hard to debug. Because
kwargswere not correctly passed on into super classes, theworker_indexremainedNonewhich was okay for testing on local runner, but fails silently when trying to load GPUs in remote runners. This PR delivers the fix for this bug.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.