Skip to content

Reworked scripts for improved reliability and utility (needs validation) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CJxD
Copy link

@CJxD CJxD commented May 28, 2021

Changes:

  • The start_valgrind.sh script has been renamed to valgrind_wrapper.template.sh to reflect its actual purpose.
  • bootstrap_valgrind.sh has been renamed to start_valgrind.sh to reflect its actual purpose.
  • valgrind_wrapper.template.sh is impregnated with the app package, log file output, and tool name prior to being written.
  • start_valgrind.sh accepts multiple options to set the package name, activity name, log path, and Valgrind tool, rather than modifying the script to enter those.
  • start_valgrind.sh now cleans up after itself by listening for a SIGINT (Ctrl + c) - on reading this, it clears the wrap property on the app and deletes the valgrind_wrapper.sh script.
  • start_valgrind.sh doesn't need an activity manually provided to run.

There is one issue I still haven't been able to get around though which I would like to be tested. I get the following in logcat when running the script:

05-28 16:22:05.280  3534  3534 E logwrapper: executing /data/local/tmp/valgrind_wrapper.sh failed: Permission denied
05-28 16:22:05.280  3532  3532 I valgrind_wrapper.sh: executing /data/local/tmp/valgrind_wrapper.sh failed: Permission denied
05-28 16:22:05.281  3532  3532 I valgrind_wrapper.sh: valgrind_wrapper.sh terminated by exit(255)

The script has 0777 permissions on it, so not sure why that could be. See if it happens for you.

Also, I have not been able to successfully run my app by manually passing an activity via the -a flag: see if that works for you too, as the actual start command hasn't changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant