[dotNew] update extension API #17453
Open
+267
−245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raycastbot
added
extension fix / improvement
|
Thank you for your contribution! 🎉 🔔 @natterstefan @xmok you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. Due to our current reduced availability, the initial review may take up to 10-15 business days |
xmok
reviewed
Mar 1, 2025
There was a problem hiding this comment.
Feel free to add yourself as a contributor in "package.json" if interested.
And re: metadata, you can modify the script:
right now it flattens the tables but you could choose to keep the tables separate, map them into a flattened Array alongside the category then we could use the category for a filter!
| @@ -41,7 +31,7 @@ export default function main() { | |||
| key={index} | |||
| title={url} | |||
| subtitle={text} | |||
| icon={getFaviconUrl(url)} | |||
| icon={getFavicon("https://" + url)} | |||
There was a problem hiding this comment.
For consistency, can we keep the same fallback?
fallback: Icon.Globe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was trying to add a category filter in the search bar mentioned in #17169. However, the metadata can not support this.
So, I updated the API in passing.