Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix preset issues #191

Merged
merged 1 commit into from
Mar 3, 2025
Merged

fix preset issues #191

merged 1 commit into from
Mar 3, 2025

Conversation

samuelkraft
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ray-so ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 9:41am

Copy link
Member

@thomaspaulmann thomaspaulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a small comment but shouldn't block landing.

@@ -67,7 +67,7 @@ export default async function Page({ params, searchParams }: Props) {
notFound();
}

const preset = parseURLPreset(searchParams.preset as string);
const preset = parseURLPreset(searchParams.preset as string) as Preset;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to make parseURLPreset return Preset to avoid the typing here.

@samuelkraft samuelkraft merged commit 9a9a33c into main Mar 3, 2025
2 checks passed
@samuelkraft samuelkraft deleted the wrfaerg branch March 3, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants