Replace chdir to /var/empty with secure creation of tempdir and later removal #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a good solution to get rid of the /var/empty-thing! I'll test it today or tomorrow. |
|
Did you have any chance to test this. |
|
Oh sorry I've totally forgotten this. Will test it after work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace chdir("/var/empty") with chdir(emptydir) where emptydir is securely created by tempfile module. After actions complete the dis is removed with shutil.rmtree.
This way the code becomes a bit more portable and not so dependant on specific dir existence (LXC being one of the cases, ubuntu the other, and my specific case the third)
PS: The diff is a bit confusing but in reality the chdir call (and some code after it which i believe is protected by it) is wrapped in