feat: migrate frontier Groups APIs to Connect RPC

[rohilsurana]

Summary

✅ COMPLETE: Successfully migrated all Groups APIs from gRPC to Connect RPC format as part of the IAM API standardization initiative.

🎉 Progress: 11/11 APIs Complete (100%) 🎉

✅ All APIs Migrated Successfully:

• ListGroups - Lists groups with organization filtering (pre-existing)
• ListOrganizationGroups - Lists all groups within an organization with optional member inclusion
• CreateGroup - Creates new groups with metadata validation and audit logging
• GetGroup - Retrieves group details by ID with optional member information
• UpdateGroup - Updates existing group configurations with comprehensive validation
• ListGroupUsers - Lists users within a specific group with optional role information
• AddGroupUsers - Adds users to a group with organization validation
• RemoveGroupUser - Removes a user from a group with admin protection
• EnableGroup - Enables a disabled group
• DisableGroup - Disables an active group
• DeleteGroup - Permanently deletes a group

🏆 Migration Achievements:

• 100% API Coverage: All 11 Groups APIs successfully migrated
• Comprehensive Testing: 50+ test cases covering all error scenarios and success flows
• Zero Breaking Changes: All original business logic preserved with identical functionality
• Modern Interface: Enhanced type safety and improved tooling support with Connect RPC
• Quality Assurance: All builds, tests, and lints pass successfully
• Systematic Approach: Established repeatable migration methodology

Key Changes Made:

• Migrated handler signatures to use Connect RPC request/response wrappers
• Updated error handling to use Connect error codes and constants
• Preserved all business logic and validation rules
• Added comprehensive test coverage for migrated endpoints
• Maintained backward compatibility with existing proto definitions

Technical Implementation:

• Request Access: Changed from request.GetField() to request.Msg.GetField()
• Response Wrapping: Using connect.NewResponse(&ResponseType{...})
• Error Handling: Convert to connect.NewError(code, error) format
• Service Integration: Utilizing existing orgService, groupService, userService, and metaSchemaService
• Transform Functions: Reusing existing transformGroupToPB and transformUserToPB

Completed API Details:

ListGroups (Pre-existing)

• Functionality: Lists groups with organization filtering
• Features: Organization-based filtering, state filtering, super user support, group transformation
• Implementation: Already completed with Connect RPC format

ListOrganizationGroups

• Functionality: Lists all groups within a specified organization
• Features: Organization validation, optional member inclusion, comprehensive filtering support
• Test Coverage: 4 comprehensive test cases covering success and error scenarios
• Error Handling: Proper mapping of organization validation errors

CreateGroup

• Functionality: Creates new groups with full validation pipeline
• Features: Metadata validation, name auto-generation, conflict detection, audit logging
• Test Coverage: 9 comprehensive test cases covering all scenarios
• Security: Authentication validation and proper error responses

GetGroup

• Functionality: Retrieves group details by ID with optional member information
• Features: Organization validation, optional member inclusion, user transformation
• Test Coverage: Comprehensive test suite covering all validation scenarios
• Error Handling: Systematic error mapping with Connect error codes

UpdateGroup

• Functionality: Updates existing group configurations with comprehensive validation
• Features: Complete metadata validation, conflict detection, audit logging
• Test Coverage: 10 comprehensive test cases covering all validation scenarios
• Security: Proper authorization and conflict resolution

ListGroupUsers

• Functionality: Lists users within a specific group with optional role information
• Features: Organization validation, optional role retrieval, logger integration
• Test Coverage: 7 comprehensive test cases covering all scenarios
• Performance: Efficient user and role transformation with error handling

AddGroupUsers

• Functionality: Adds users to a group with organization validation
• Features: Multi-user support, organization validation, bulk operations
• Test Coverage: 4 comprehensive test cases covering all scenarios
• Scalability: Support for bulk user addition operations

RemoveGroupUser

• Functionality: Removes a user from a group with admin protection
• Features: Critical admin protection preventing last admin removal
• Test Coverage: 6 comprehensive test cases covering all scenarios
• Security: Group governance ensuring administrative continuity

EnableGroup

• Functionality: Enables a disabled group
• Features: Organization validation, simple enable operation
• Test Coverage: 4 comprehensive test cases covering all scenarios
• Reliability: Clean error handling without complex business rules

DisableGroup

• Functionality: Disables an active group
• Features: Organization validation, simple disable operation
• Test Coverage: 4 comprehensive test cases covering all scenarios
• Consistency: Mirror implementation of EnableGroup with proper validation

DeleteGroup

• Functionality: Permanently deletes a group
• Features: Organization validation, permanent group removal
• Test Coverage: 4 comprehensive test cases covering all scenarios
• Safety: Complete validation before permanent deletion operation

Migration Methodology Established:

Each API followed a systematic 5-step migration approach:

1. Analysis: Review gRPC implementation for business logic and error handling
2. Implementation: Convert to Connect RPC patterns while preserving functionality
3. Testing: Create comprehensive test suite with error and success scenarios
4. Verification: Ensure build, test, and lint pass
5. Integration: Commit and track progress

Quality Metrics:

• Code Coverage: 53.0% coverage for v1beta1connect package
• Test Cases: 50+ comprehensive test cases across all APIs
• Error Handling: Complete error mapping with 15+ specific error constants
• Build Status: ✅ All builds passing
• Lint Status: ✅ Zero linting issues
• Type Safety: Enhanced with Connect RPC generic type system

Impact and Benefits:

• Modernization: Updated to modern Connect RPC framework
• Developer Experience: Improved type safety and tooling support
• Maintainability: Consistent error handling and response patterns
• Performance: Efficient request/response handling with Connect framework
• Future-Proof: Foundation for additional Connect RPC migrations

All migrated APIs maintain identical business logic while adopting modern Connect RPC interface patterns for improved type safety, better tooling support, and enhanced developer experience.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
frontier	Ready	Preview	Comment	Oct 6, 2025 7:48am

[coveralls]

Pull Request Test Coverage Report for Build 18273768303

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 244 of 306 (79.74%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.4%) to 35.49%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/api/v1beta1connect/group.go	244	306	79.74%

Totals
Change from base Build 18273738422:	0.4%
Covered Lines:	13461
Relevant Lines:	37929

---

💛 - Coveralls

[Copilot]

Pull Request Overview

This PR successfully migrates all 11 Groups APIs from gRPC to Connect RPC format as part of the IAM API standardization initiative. The migration maintains identical business logic while adopting modern Connect RPC patterns for improved type safety and developer experience.

• Migrated 10 new Group APIs to Connect RPC format (CreateGroup, GetGroup, UpdateGroup, ListOrganizationGroups, ListGroupUsers, AddGroupUsers, RemoveGroupUser, EnableGroup, DisableGroup, DeleteGroup)
• Added comprehensive error handling with Connect error codes and proper error constants
• Implemented extensive test coverage with 50+ test cases covering all success and error scenarios

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
internal/api/v1beta1connect/group.go	Implements all 10 migrated Group API handlers with Connect RPC patterns and comprehensive error handling
internal/api/v1beta1connect/group_test.go	Adds comprehensive test coverage for all migrated Group APIs with error and success scenarios
internal/api/v1beta1connect/metaschema.go	Adds group metadata schema constant for validation
internal/api/v1beta1connect/errors.go	Defines Group-specific error constants for proper error handling

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}