Skip to content

Commit

Permalink
fix: change xcom push to false as default to unblock deployment for now
Browse files Browse the repository at this point in the history
  • Loading branch information
irainia committed Feb 24, 2023
1 parent 82b0244 commit ad3c691
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions ext/scheduler/airflow/dag/dag.py.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ init_container = k8s.V1Container(
depends_on_past={{ if .JobDetails.Schedule.DependsOnPast }}True{{- else -}}False{{- end -}},
in_cluster=True,
is_delete_operator_pod=True,
do_xcom_push=True,
do_xcom_push=False,
env_vars=executor_env_vars,
{{- if gt .SLAMissDuration 0 }}
sla=timedelta(seconds={{ .SLAMissDuration }}),
Expand Down Expand Up @@ -204,7 +204,7 @@ hook_{{$hookName}} = SuperKubernetesPodOperator(
dag=dag,
in_cluster=True,
is_delete_operator_pod=True,
do_xcom_push=True,
do_xcom_push=False,
env_vars=executor_env_vars,
{{- if $t.IsFailHook }}
trigger_rule="one_failed",
Expand Down
8 changes: 4 additions & 4 deletions ext/scheduler/airflow/dag/expected_dag.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
depends_on_past=False,
in_cluster=True,
is_delete_operator_pod=True,
do_xcom_push=True,
do_xcom_push=False,
env_vars=executor_env_vars,
sla=timedelta(seconds=7200),
resources=resources,
Expand Down Expand Up @@ -167,7 +167,7 @@
dag=dag,
in_cluster=True,
is_delete_operator_pod=True,
do_xcom_push=True,
do_xcom_push=False,
env_vars=executor_env_vars,
resources=resources,
reattach_on_restart=True,
Expand Down Expand Up @@ -205,7 +205,7 @@
dag=dag,
in_cluster=True,
is_delete_operator_pod=True,
do_xcom_push=True,
do_xcom_push=False,
env_vars=executor_env_vars,
resources=resources,
reattach_on_restart=True,
Expand Down Expand Up @@ -243,7 +243,7 @@
dag=dag,
in_cluster=True,
is_delete_operator_pod=True,
do_xcom_push=True,
do_xcom_push=False,
env_vars=executor_env_vars,
trigger_rule="one_failed",
resources=resources,
Expand Down

0 comments on commit ad3c691

Please sign in to comment.