Skip to content

Commit

Permalink
Merge branch 'master' of github.com:razir/GithubTestClient
Browse files Browse the repository at this point in the history
  • Loading branch information
Anton Hadutski committed Dec 2, 2018
2 parents 98bfb59 + 120c3a5 commit 4c2f2a3
Showing 1 changed file with 25 additions and 23 deletions.
48 changes: 25 additions & 23 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,55 +19,57 @@ This client is made for test purpose only. It's not related to Gitbub Inc. in an

### Data package:
- *main*
-- All models
* All models
### Datasource package
- *main*
-- All repositories
-- All room database related code
-- All API related initialization code
* All repositories
* All room database related code
* All API related initialization code
- *test*
-- Unit tests for some repositories
* Unit tests for some repositories
- *androidTest*
-- AndroidJUnit tests for untested by JUnit repositories
-- AndroidJUnit tests for room db
-- AndroidJUnit tests for Http client Interceptor
* AndroidJUnit tests for untested by JUnit repositories
* AndroidJUnit tests for room db
* AndroidJUnit tests for Http client Interceptor
### Dependency injection [DI] package
- *main*
-- Koin modules definition related code
* Koin modules definition related code
- *test*
-- Koin modules definition Unit tests
* Koin modules definition Unit tests
### Domain.UseCase package
- *main*
-- All use cases
* All use cases
- *test*
-- Some use cases JUnit tests
* Some use cases JUnit tests
- *androidTest*
--AndroidJUnit tests for the rest of untested by JUnit use cases
* AndroidJUnit tests for the rest of untested by JUnit use cases
### Extensions package
- *main*
-- Kotlin extensions code
* Kotlin extensions code
- *androidTest*
--AndroidJUnit for some extensions
* AndroidJUnit for some extensions
### Presentaion package
- *main*
-- All UI related code + ViewModels
* All UI related code + ViewModels
- *test*
-- JUnit tests for ViewModels
* JUnit tests for ViewModels
- *androidTest*
-- Espresso+ Kakao tests for Activities and Fragments
* Espresso+ Kakao tests for Activities and Fragments

### Instructions to run
## Instructions to run

To run from the sources you need:
1) create your own github oauth application
#### To run from the sources you need:
1) create your own github oauth application with redirect url ```https://google.com```
2) create text file ```github_client.properties``` in the root project folder with app details from step 1.
client_id={your_client_id_here}
client_secret={your_client_secret_here}

To run from the apk:

#### To run from the apk:
1) Download the latest release from here
### Short video demostrantion of app workflow

### Short video demostrantion of app workflow
https://drive.google.com/open?id=1L9BRnS7qELimUwrrneMK-R3ndNktPEmO
### Todos
- Write more UI tests
- Add more functionality
Expand Down

0 comments on commit 4c2f2a3

Please sign in to comment.