Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New contact page #101

Merged
merged 6 commits into from
Mar 21, 2024
Merged

New contact page #101

merged 6 commits into from
Mar 21, 2024

Conversation

adityaraute
Copy link
Collaborator

Motivation and Context

Old Contact Page was messy. Also, we had a slight change in requirements.

Fixes #96

Description

Created a different page and a new CSS file.
Also created a google form which has been linked.

How Has This Been Tested?

Tested on browser - Google Chrome. Desktop and Web.

Screenshots (if appropriate):

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.

@adityaraute adityaraute linked an issue Mar 20, 2024 that may be closed by this pull request
1 task
@adityaraute
Copy link
Collaborator Author

@agriyakhetarpal Would be nice to get your comments on the following:

  1. If the link and UI work as desired.
  2. Ways to improve the UI/UX for next iteration.

I'll merge the changes by Friday, if no comments received from you

Copy link
Collaborator

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense, thanks. For improving the UI further, it should be possible to embed the Google Form directly into the page and stack the divs vertically?

@adityaraute
Copy link
Collaborator Author

Divs are being stacked vertically in mobile view. So you suggest we do so in Desktop View too?

Embedding Google Form, I'm afraid, could mislead the beneficiaries perhaps, as they are prioritised over the donors for contact.

@agriyakhetarpal
Copy link
Collaborator

Divs are being stacked vertically in mobile view. So you suggest we do so in Desktop View too?

Embedding Google Form, I'm afraid, could mislead the beneficiaries perhaps, as they are prioritised over the donors for contact.

Doing so in Desktop view is up to you. I had suggested that just because it would have made it easier to embed the Google Form in the page, so if you have second thoughts on that – that's alright, we can leave it.

@adityaraute
Copy link
Collaborator Author

Yeah I feel Embedded Google Form won't work here.
Thanks for the review! Merging now.

@adityaraute adityaraute merged commit ab15e09 into main Mar 21, 2024
1 check passed
@adityaraute adityaraute deleted the new-contact-page branch March 21, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Embed Google Form for contact
2 participants