Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto create release on PR closure to deployment branch #146

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

devilsaint99
Copy link
Contributor

Auto create release on PR closure to deployment branch

Motivation and Context

Fixes Issue #91

Description

How Has This Been Tested?

Screenshots (if appropriate):

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@adityaraute
Copy link
Collaborator

I am seeing this error when testing on my fork.

image

How can this be prevented? I thought tags were to be generated automatically.

@devilsaint99
Copy link
Contributor Author

@adityaraute oops I didn't update the description.... So tags won't be generated. What we would do is when we create the PR, in title we would mention tag like "Version: v<major.minor.patch>" For eg. Version: v1.2.3.
For body/description of the release i.e. a summary of changes you can put in release.md, like what are the new changes in this release

@adityaraute
Copy link
Collaborator

It worked, this looks great

For anyone wanting to check, see the tag here

Merging this PR. Thanks for your contribution @devilsaint99

@adityaraute adityaraute merged commit db27c86 into rbjks:main Jun 10, 2024
@adityaraute adityaraute linked an issue Jun 10, 2024 that may be closed by this pull request
1 task
adityaraute added a commit that referenced this pull request Jun 10, 2024
* Adding details in English

* Added Hindi Translations

* Added translation for the h4 tags

* Contact page title  (#111)

* add contact page

* update

* Add a hover effect feature

Co-authored-by: Mohammed Luriwie Iddrisu <[email protected]>

* Updating missing alt-property for image (#128)

* changes to Intro section(#133)

Changed text colours and margins for desktop and mobile view

* added hamburger (#137)

* Fixed contact section height and css clean-up

* Reverted contact.html indentation fixes

* Update README.md with the details of the project:

* Update README.md with the details of the project:

* Rebuild README.md:

* Rebuild README.md:

* Redesigned README.md:

* Redesigned README.md:

* Redesigned README.md:

* Redesigned README.md:

* Fixed incorrect path in gallery.js

Now the gallery shows all desired activities

* Commented Twitter widget (#144)

* chore: Update CSS to improve footer image and text styling

* Update README.md (#148)

* Update README.md

Added RepoRater

* Update README.md

Added RepoRater badge

* auto create release on PR closure to deployment branch (#146)

One should add `Version: vX.Y.Z` to the title of the PR for creating a tag.

---------

Co-authored-by: Gokil P <[email protected]>
Co-authored-by: Mohammed luriwie Iddrisu <[email protected]>
Co-authored-by: Mohammed Luriwie Iddrisu <[email protected]>
Co-authored-by: Adam Basha <[email protected]>
Co-authored-by: CampbellBrim <[email protected]>
Co-authored-by: Mohit  Bhandari <[email protected]>
Co-authored-by: Sidharth Sreekumar <[email protected]>
Co-authored-by: Md. Afzal Hassan Ehsani <[email protected]>
Co-authored-by: Rohan Ram <[email protected]>
Co-authored-by: Caio Busarello Dutra <[email protected]>
Co-authored-by: Agriya Khetarpal <[email protected]>
Co-authored-by: Harsh Khandelwal <[email protected]>
Co-authored-by: Anshul Suresh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add a workflow to declare a release
2 participants