ED-319 move identity provider configuration in domain conf #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynslug
reviewed
Dec 8, 2021
apps/fistful/src/ff_provider.erl
Outdated
| id(#{id := ID}) -> | ||
| ID. | ||
| id(#{id := Ref}) -> | ||
| Ref#domain_IdentityProviderRef.name. |
There was a problem hiding this comment.
Хм, я кстати не уверен, что ничего не сломается у потребителей domain config (например, тот же control center), если ты поле в ref называешь как-то отлично от id. Я б конечно на всякий случай переименовал в рамках конвенции, пока не поздно.
keynslug
approved these changes
Dec 10, 2021
| -spec list_providers() -> [provider_ref()]. | ||
| list_providers() -> | ||
| #'VersionedObject'{ | ||
| % version = Version, |
There was a problem hiding this comment.
Теперь получается можно взять отсюда версию, и порешать TODO из функции выше. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Перед deploy'ем данных изменений, необходимо: