Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace include guards with "#pragma once" #506

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

MeanSquaredError
Copy link
Contributor

As per our previous discussion here #500
this PR replaces the header include guards with #pragma once in all header files and in the python generator scripts. All tests (core+postgresql+mysql+sqlite3) ran successfully.

The #pragma once is not standard but is supported by all major C++ compilers and easier to maintain than the old-style #ifndef #define...#endif include guards.

@rbock rbock merged commit a085d73 into rbock:main Jul 25, 2023
@rbock
Copy link
Owner

rbock commented Jul 25, 2023

Thanks! I hope you did automate this change :-)

@MeanSquaredError
Copy link
Contributor Author

I did automate the change, but then had to go manually over all the files just to make sure that the regular expressions in my script updated the files correctly :-)

@MeanSquaredError MeanSquaredError deleted the pragma_once branch July 26, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants