Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat code with black #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

therefromhere
Copy link
Contributor

@strix-technica
Copy link
Collaborator

strix-technica commented Jun 30, 2019

This is @rcastberg's project so it's his call but I can't say I'm keen on this. It will cost time without any obvious functional benefit. At the same time, it will break anybody who's customised code without having their customisations pulled back into mainline.

I realise that my/René's coding style might not be to everyone's taste but unless you're willing to put in the lion's share of dev work, it's probably better to leave it in a format that is comfortable for those doing the majority of the work.

@therefromhere
Copy link
Contributor Author

Yeah that's fine, I thought I'd put it up and see if you guys were ok with it since black is becoming a very popular formatter for python. I won't be offended if you reject the PR though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants