ethereum provider, updated crypto suite #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- never mind emacs config - lint:types: typescript devdependencies - .flowconfg -> jsconfig.json - lint:eslint: airbnb / Agoric style - add chrome global - update webpack devDependencies
- don't import RHOCore; it's no longer available
- crib from metamask:
- adopt injectScript() DOM manipulation
- use "run_at": "document_start" in manifest
- refactor inject() to take string form of function
- use Record<string, unknown> for type of mutable window
- factor install() out of runInPage()
- provide autoRefreshOnNetworkChange setter on window.ethereum
- clean up logging
- factor out inPage.js
- integrate sigTool with ethereum provider (WIP)
- start with 027aca3deb4a Fri Apr 12 11:35:13 2019 -0500 - style: migrate secretStorage.js from flow to ts/jsdoc fix: scrypt cost parameter (n) was unusually large 1024 is what I found in one of my key files and in some metamask source code. 262144 came from a test vector. https://github.com/juanelas/scrypt-pbkdf shows 5 to 28 seconds for 2**18=262144
- dependencies: crypto, ethereumjs, script, uuid-random - stream??? - webpack config - ethProvider: provide ethAddr - nacl -> crypto - sigTool - don't depend on messageBus - more flow -> @ts-check (jsdoc + typescript) - use secretStore
- toward postMessage authentication: check event.source (ew. ACLs don't.) - use q/a sequence numbers to filter irrelevant messages - removeEventListener after round trip is complete - handle errors; log unexpected conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #26
fixes #28
fixes #9
unfortunately, it breaks critical functionality (#30) and adds a performance bug (#29).
@Bill-Keuntje I'd like to assign this to you for review, but it looks like I need you to accept the invitation first.
cc @jimscarver