-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a latest command that shows the latest released version #77
base: master
Are you sure you want to change the base?
Conversation
@mattwynne Thanks for your contribution - really good! Just one minor comment - if you could move that logic out of the command it would be great and then I think we are ready to merge Edit: just authorized the checks and it seems some of them failed - do you mind checking, please? |
Thanks for taking a look @rcmachado and sorry for the lag - my GitHub notifications were going into a folder I don't look in very often. I'm a bit confused by the check failures. The The goreleaser error looks like maybe their manifest format has changed between versions of goreleaser? The error says:
|
@rcmachado I'd appreciate some help with the linter / goreleaser warnings if you can spare the time. I'm a bit stuck understanding their feedback. |
I think it would be more unix'y (i.e. versatile) if this were refactored to a Suggested output from
The column headers would not be printed (just like
|
I thought about this some more, and implemented #78 which adds a WDYT? |
I think a The JSON output seems like a great idea to me, very versatile! Can we have both!? |
@mattwynne we don't need a new |
Json output
@mattwyne sorry for the delay - time has been a scarce resource lately. About CI process failing, couldn't take a look yet but could be something related to tools been updated and rules changed? I don't build this project since some time |
Add --tag-format option to the release command
Remove deprecated fields from goreleaser config
Not sure why we'd want to release a PR
50c3258
to
4330f9b
Compare
The `build` job will run on a PR or a push to `main`. The `release` job just runs on a tag.
* Add a latest command that shows the latest released version * Clarify help text * Add another test case and refactor * Update README * Add changelog entry for rcmachado#77 * Move ReleasedVersions onto ChangeLog model * Update CHANGELOG * Fix ref to parser module * Reformat for linter Co-authored-by: Matt Wynne <[email protected]>
Any news on this? I would like to see this. |
Hey @tburschka. We have this implemented in our fork: https://github.com/cucumber/changelog |
I wanted a way to get the latest released version number out of my CHANGELOG.md
I hope this is useful!
I've test-driven the changes, so hopefully it should all be good for any refactoring.
I did consider adding this as a default to the
show
command if you didn't specify a version to show, but that command doesn't actually show the version number, which is what I need.This does allow you to do
changelog show `changelog latest`
to show the details of the latest release.Note that this is my first Go code, so:
a) please be gentle with your feedback
b) thanks for writing such an easy-to-navigate codebase that I could learn from and so easily contribute to!