Eatyourpeas/issue96 #104
Merged
Eatyourpeas/issue96 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eatyourpeas please could you add a more descriptive title to your PRs? :) Even just copying the first line of the description. It really helps anyone who is looking at the GitHub notification stream or is going back through git blame or logs to investigate why something was added |
|
I am so sorry yes of course - you have asked me to do this before. my bad. It is largely because I use VS Code for the PR workflow which prepopulates the title field and I am so focussed on writing a detailed PR that I forget the title. Apologies and will do better :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds spinners to htmx request radio buttons and csv upload button
Code changes
Add daisyui spinner and css classes to show/hide + hyperscript
Related Issues
closes #96 #64
Mentions
@mentions of the person or team responsible for reviewing proposed changes.