upload-csv-form-validation-fix-implements-single-submission #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all are being called
… all submitted with form instance
csv_upload and clean_ in visitform methods now being called correctly remove quarter from submission list and patientlist. create patient quarter now needs removing
mbarton
added
Pending-on-STAGING
Overdue-on-STAGING
and removed
Pending-on-STAGING
labels
|
Overdue on STAGING (merged by @eatyourpeas 15 minutes and 3 seconds ago) What's gone wrong? |
|
The container is now crashing on startup in the deployment. Annoyingly there aren't any log messages coming from it either. I'll see if I can start it locally |
|
It I think is because the migrations got reset when the models changed.
Those should not now change
…On Mon, 12 Aug 2024, 10:15 Michael Barton, ***@***.***> wrote:
The container is now crashing on startup in the deployment. Annoyingly
there aren't any log messages coming from it either. I'll see if I can
started it locally
—
Reply to this email directly, view it on GitHub
<#238 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAICOV5PXHQZBJYCA7OQEXLZRB4L7AVCNFSM6AAAAABMJ3JZDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBTGQ3TAMZYGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Ah yes sorry there is an error it just took a while to come through in the Azure logs: |
|
Seen on STAGING (merged by @eatyourpeas 90 hours, 52 minutes and 8 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Following the merging of @mbarton branch unifying validation across the project into the form classes, the validation then broke. As well as fixes to this, the PR also removes quarter as a field in the Submission model and the implementations in the patient form where this was previously added in. Quarter has been removed also from all the templates
Code changes
patient_form.py: removes quarter as a custom fieldvisit_form.py: addsclean_**functions for all the select fields to reject any invalid submitted keys. Accepts None values. TODO: will need to flag errors if for example smoking_status has a valid selection but no associated date.csv_upload.py: removes quarter as parameter to function which had been previously added and all references to it. Refactors Submission creation to set to inactive previous submission before deletes (overwrite previous submissions #235). Refactors Transfer record creation as did not work following change in table structure.submission.py: model refactor - removesquartermixins.py: adds test for related PDU through the Transfer tableviews/patient.py: removes references to quarter in filterviews/submission.py: removes references to quarterviews/visit.py: refactorsactive_cohortto submissionDocumentation changes (done or required as a result of this PR)
Possibly needs doing still. Needs likely a section on submission but should do this when clearer how quarters will be handled.
Related Issues
Addresses #234, #231