Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom error pages #286

Draft
wants to merge 13 commits into
base: live
Choose a base branch
from
Draft

Custom error pages #286

wants to merge 13 commits into from

Conversation

reecehill
Copy link
Contributor

Overview

TBC.

Code changes

TBC.

Documentation changes (done or required as a result of this PR)

nil.

Related Issues

#21

@reecehill reecehill self-assigned this Sep 24, 2024
@reecehill reecehill linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link
Member

@eatyourpeas eatyourpeas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reecehill I have fixed the broken tests here - please check over to be happy. I put all the error tests into a single class and a single file: hope that is ok.

The permissions tests were breaking because the custom 403 did not explicitly set the error code to 403, so this was therefore returning 200. Hope that makes sense. I have only tested the 403 in the UI, not the 500 or 404 etc.

Also, @mbarton comment here - not sure about the wording in the templates. Phrases like This may be due to a client error or a malformed request. is quite jargon-filled.

Perhaps could simplify the wording for each? I agree though needs to be friendly and where possible offer users option to reach out to NPDA team if they are having difficulties. I wonder if we could get the team to do us a custom background for this, as they did in E12

I am puzzled though because the tests are now all passing for me locally but are still apparently failing on github.

Copy link
Member

@eatyourpeas eatyourpeas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing on github:
Process completed with exit code 137.
This means insufficient memory, so not sure why that would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

403/404/500 custom pages
2 participants