Bypass 2FA Token in local development #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anchit-chandran <[email protected]>
Signed-off-by: anchit-chandran <[email protected]>
Signed-off-by: anchit-chandran <[email protected]>
Signed-off-by: anchit-chandran <[email protected]>
Signed-off-by: anchit-chandran <[email protected]>
Signed-off-by: anchit-chandran <[email protected]>
Signed-off-by: anchit-chandran <[email protected]>
eatyourpeas
approved these changes
Jun 1, 2024
There was a problem hiding this comment.
Thank you Anchit for this nice piece of work. Looks all good.
One thing I have changed - would like to know whether you agree - is that I have removed the requirement to be both DEBUG and superuser to skip 2FA. My rationale is that 2FA is for production only, when DEBUG will be False, and I have found otherwise that if we are testing with different user accounts, it throws a 403.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got working with help of @eatyourpeas thanks!
Overview
When in local development (
settings.DEBUG=True), bypass the 2FA token step on login.This improves the developer experience.
Code changes
npdaapp to only use 2FA / custom auth urlsLoginAndOTPRequiredandlogin_and_otp_requiredmixin&decorator.post()method of theRCPCHLoginViewclass to skip past the normal auth workflow if in debug modeDocumentation changes (done or required as a result of this PR)
Related Issues
Mentions