Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug-testing-aggregations #553

Merged
merged 141 commits into from
Aug 26, 2023
Merged

Debug-testing-aggregations #553

merged 141 commits into from
Aug 26, 2023

Conversation

eatyourpeas
Copy link
Member

This is a large refactor by @anchit-chandran

  • aggregation factors were rewritten to return counts of eligible, ineligible and passed measures.
  • the KPIAggregation model was rebuilt to include a base model, and models for each level of abstraction
  • tests were added for these aggregation calculations
  • the javascript chartjs was deprecated and replaced with plotly for SSR charts

@anchit-chandran
postcodes io fix
0a7ddd2 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
update E12MaD factory params
0dd5e93 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds initial refactor aggregate fn
6b3f900 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
initial working test and working refactored aggregate kpi value count
0424f5e 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
updates refactor aggregate fn type hint to return Dict
5be0ecd 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
updates test to test all possible kpis
a741ea2 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
change args for CreateKPIMetrics
c029bab 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
set sex to female for setting kpi 8 valproate eligibility
7a2e18f 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds test_get_kpi_value_counts_eligible_6_8_10_pass_fail
b3c6f9e 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds final test for refactored agg function
b327d86 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
change postcodes io env url in docker compose
ce11e7c 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
fix complete fields count to not include CESS input as per updated e1…
199e866 
…2 guidance

Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
add + refactor __get_abstraction_sublevel_from_level
347d980 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
rms extra line
f3335a9 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds refactored kpiagg model
06785e5 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
makes migrations for kpi agg model
9bf3f05 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
rm typo
0924bf3 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
refactor usage of kpi aggregation model calls
ea2dad3 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
rms get_filtered_cases fn
8097fc6 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
rms get filtered cases fn
88f8942 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
initial working kpiaggregation workflow
537766f 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds kpi aggrgation table as migration
4631a9c 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds initial country get kpi agg from model
1e2cee4 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds tags for processing agg data
caee068 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds country agg kpi data for org view context
4917681 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
charts country kpi agg data in separate viz
4f1922f 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds debug code
a94780e 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
aggs oncept
7e0d16c
@anchit-chandran
implements improved aggregation value counts function and passing tes…
93e1a97 
…t for org abstraction
@anchit-chandran
adds enum abstraction levels
9124616
anchit-chandran and others added 28 commits August 23, 2023 11:44
@anchit-chandran
adds print statement for updating kpi agg model
5ed149c 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
updates update code for update_agg fn
830a9ff 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds all abstraction individual kpi pies
ebc576c 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
further adjust individual kpi pie styling
7a40fb9 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds kpi agg model seed in migration
e249b83 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
error handling template for when agg model field is none
63dff2b 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds kpi bars to context
c55fc13 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
update template to render bar
08e6160 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
increases org container size
5320738 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds initial graph layout
44ba976 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
bar chart height + stylings
db58e9e 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
refactors viz into modules
4ea9817 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
rm mode bar options zoom and pan
a2c5713 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
fix cheyne child dev centre incorrect postcode + ons region postcode …
8b318a5 
…fail handle

Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
fix pie divide by 0
a83b4ce 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
add scroll to chart
16edb80 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
moves individual charts under summary_kpi_table
b4c6806 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
increase xaxes width
12c4800 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adjust bar chart hoverlabel orientation
f60691b 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
move charts under main table
3bfe645 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
rm border top from progress kpi pies
1a7b9e6 
Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
adds avg line + handling 0 eligible cases for pct passed query in view
16eb248 
Signed-off-by: anchit-chandran <[email protected]>
@eatyourpeas
remove menu tabs
01dc08d
@eatyourpeas
replace dropdown
d3c5291
@eatyourpeas
include inside segments
0982923
@eatyourpeas
refactor templates
7016333 
include navigation buttons
restyle abstraction tiles
@eatyourpeas
tooltip styling
04be37c
@eatyourpeas
fix tooltip data - replace numpy array
fc13221
@eatyourpeas eatyourpeas merged commit 63d6fb4 into development Aug 26, 2023
1 check passed
@eatyourpeas eatyourpeas deleted the debug-testing-aggregations branch August 26, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eatyourpeas @anchit-chandran