New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vite extension #457

Merged

barryvdh merged 1 commit into rcrowe:master from daniser:fix/vite-ext

Feb 26, 2025

Contributor

daniser commented Feb 26, 2025

New Vite extension (#435) have several problems:

its output is not marked as html safe, so it mangles html tags making extension unusable;
you can't pass second argument ($buildDirectory) while calling Vite;
some parts of implementation makes little sense.

This PR fixes all these issues and simplifies code.


          Fix Vite extension

1fdd332

barryvdh merged commit 8520b08 into rcrowe:master

13 checks passed

daniser deleted the fix/vite-ext branch

February 26, 2025 12:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet