-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to directly load triples into BasicHDT #25
Conversation
@mielvds @joachimvh @laurensdv This is just what we needed for the management server. Now we can set up a pipeline unzip / clean / etc. without having to materialize. |
@LaurensRietveld @wouterbeek You will also like this; support for piping will likely simplify the LOD Laundromat internal pipeline. |
Cool stuff Ruben, thanks. This will indeed simplify some parts in our pipeline. |
@LaurensRietveld Correct, it works the same way as generating HDT's from an input file, with the difference that this new method accepts a triple iterator instead of a file. |
Before I merge, what is the overlap between the |
@mielvds You're right, I could abstract some things. The only real difference is the |
@mielvds All overlapping code between the |
9a8e48d
to
532823c
Compare
@rubensworks I did an attempt at merging this with the current develop branch, but I can't make it compile. There seems to be an issue with the inline functions you declared:
Could you have a look? Result is in https://github.com/rdfhdt/hdt-cpp/tree/rubensworks-feature-loadtriples-single |
@mielvds Apparently the Makefile isn't using c++11, in which lambda support was introduced. So either we add |
I'd say; try C++11, and if Travis takes it, it's good. |
If it doesn't break backwards compatibility, fine by me. |
We can probably remove the gzip dependency after this PR? |
Could you please rebase this on the latest develop? |
@rubensworks Based on your comment #77 (comment), how do we proceed with this one? |
@RubenVerborgh As this PR only adds a new method for streaming triples into So I suggest closing this PR, unless someone would require this functionality for something else. |
Agree on closing, thanks! |
@rubensworks can I delete the branch? |
Or, should we rebase this branch on dev and reopen this pr? I've yet to see anybody to convert a gzipped ntriples file to hdt, despite what the Readme says. And, got the impression @rubensworks that this pr can be used to convert gzipped files to hdt, is that correct? |
Sorry, ignore my last message (context: #47 (comment)) |
This allows triples to be directly loaded into a BasicHDT without having to read them from a file.