Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DELIA-66586: WPEFramework crash with signature "WPEFramework::Plugin:… #5849

Open
wants to merge 1 commit into
base: sprint/24Q4
Choose a base branch
from
Open

DELIA-66586: WPEFramework crash with signature "WPEFramework::Plugin:… #5849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions Packager/Packager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,23 +73,25 @@ namespace {
{
ASSERT(_service == service);

_service->Unregister(&_notification);

if (_implementation->Release() != Core::ERROR_DESTRUCTION_SUCCEEDED) {

ASSERT(_connectionId != 0);
if (_service != nullptr) {
_service->Unregister(&_notification);
}

RPC::IRemoteConnection* connection(_service->RemoteConnection(_connectionId));
if (_implementation != nullptr) {
if (_implementation->Release() != Core::ERROR_DESTRUCTION_SUCCEEDED) {
ASSERT(_connectionId != 0);

// The process can disappear in the meantime...
if (connection != nullptr) {
RPC::IRemoteConnection* connection(_service->RemoteConnection(_connectionId));

// But if it did not dissapear in the meantime, forcefully terminate it. Shoot to kill :-)
connection->Terminate();
connection->Release();
}
}
// The process can disappear in the meantime...
if (connection != nullptr) {

// But if it did not dissapear in the meantime, forcefully terminate it. Shoot to kill :-)
connection->Terminate();
connection->Release();
}
}
}
_service = nullptr;
_implementation = nullptr;
}
Expand Down
Loading