New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix of broken links in DFG Checklist and Short Questionnaire #209

Merged

Zack-83 merged 3 commits into rdmorganiser:master from yvgrossmann:master

Oct 13, 2023

Collaborator

yvgrossmann commented Sep 21, 2023

No description provided.


          Fixing of broken links etc.

2d422b5

laura-tte reviewed

View reviewed changes

rdmorganiser/questions/fhpshort.xml Outdated Show resolved Hide resolved

laura-tte reviewed

View reviewed changes

rdmorganiser/questions/fhpshort.xml Outdated Show resolved Hide resolved

laura-tte reviewed

View reviewed changes

rdmorganiser/questions/fhpshort.xml Outdated Show resolved Hide resolved

laura-tte reviewed

View reviewed changes

rdmorganiser/questions/fhpshort.xml Outdated Show resolved Hide resolved

laura-tte reviewed

View reviewed changes

rdmorganiser/questions/fhpshort.xml Outdated Show resolved Hide resolved

laura-tte reviewed

View reviewed changes

rdmorganiser/questions/fhpshort.xml Outdated Show resolved Hide resolved

Collaborator

laura-tte commented Sep 21, 2023 •

edited

Loading

Ich habe noch folgenden broken link entdeckt (bei fhpshort.xml):

Inhaltliche Einordnung / Daten (nur deutsch): https://www.gesetze-im-internet.de/bdsg_1990/ und https://www.gesetze-im-internet.de/bdsg_1990/__3a.html

Sonstiges (bei fhpshort.xml):

Technische Einordnung / Formate (deutsch und englisch): http://www.wissgrid.de/publikationen/Leitfaden_Data-Management-WissGrid.pdf -> führt nicht auf das PDF, sondern auf https://www.wissgrid.de/
Metadaten und Referenzierung / Persistente Identifikatoren: http://training.dasish.eu/training/3/ -> Mein Browser (Google Chrome) gibt hier eine Sicherheitswarnung.

Member

Zack-83 commented Sep 21, 2023

Super Arbeit ihr zwei!

WissGrid wurde schon in der PR #207 repariert

Member

Zack-83 commented Sep 21, 2023

Nur als Idee... Wäre besser, wenn wir den fachspezifischen Links verzichten würden und nur zur Hauptseite https://www.dfg.de/foerderung/grundlagen_rahmenbedingungen/forschungsdaten/empfehlungen/index.html bzw. https://www.dfg.de/en/research_funding/principles_dfg_funding/research_data/recommendations/index.html hinweisen würden?

Member

Zack-83 commented Sep 28, 2023

@yvgrossmann @laura-tte wie weit seid ihr?

Collaborator

laura-tte commented Oct 6, 2023

@Zack-83 Das Review ist fertig. Am Code habe ich bisher nichts geändert.


          Apply suggestions from code review

585d86b

Zack-83 reviewed

View reviewed changes

rdmorganiser/questions/fhpshort.xml Outdated Show resolved Hide resolved


          Apply suggestions from code review

3abb1f5

Zack-83 approved these changes

View reviewed changes

Zack-83 requested a review from thrichter-FD

October 13, 2023 12:32

Zack-83 merged commit 65e4165 into rdmorganiser:master

1 check passed

Zack-83 added a commit that referenced this pull request


          Fix of broken links in DFG Checklist and Short Questionnaire (#209)

d77a11f

* Fixing of broken links etc.

---------

Co-authored-by: Giacomo Lanza <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet