Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute für FoDaKo-DFG hinzugefügt #273

Merged
merged 7 commits into from
Jun 25, 2024
Merged

Conversation

Zack-83
Copy link
Member

@Zack-83 Zack-83 commented Jun 5, 2024

Attribute für die FoDaKo DFG-Kataloge hinzugefügt.

Attribut Änderung
deletion neu hinzugefügt
deletion/reasons neu hinzugefügt
deletion/technique neu hinzugefügt
sensitive_data/personal_data/consent/content neu hinzugefügt
sensitive_data/personal_data/consent/how_obtained neu hinzugefügt
sensitive_data/personal_data/protection_concept neu hinzugefügt
sensitive_data/personal_data/protection_concept/checked neu hinzugefügt
sensitive_data/personal_data/protection_concept/rights_management neu hinzugefügt
sensitive_data/personal_data/protection_concept/workflow neu hinzugefügt

Attribute für die FoDaKo DFG-Kataloge hinzugefügt
@Zack-83
Copy link
Member Author

Zack-83 commented Jun 5, 2024

@torsten-rathmann bitte Anleitung korrigieren:

  • sensitive_data/personal_data/protection_concept/rights_management in der Liste der "neuen" Attribute einschließen
  • project/dataset/documentation, project/dataset/documentation/where, project/dataset/documentation_on_request, project/dataset/ipr/status, project/dataset/reuse_existing, project/legal_aspects/official_approval/statutatory_approval/conditions, project/costs/other_research_output, project/costs/other_research_output/personnel, project/costs/other_research_output/non_personnel, project/other_research_output, project/other_research_output/plan aus der Liste streichen (in der Domäne doch schon vorhanden)
  • "Gehen Sie dafür mit Admin-Rechten auf Management → Domäne ..." mit "Gehen Sie dafür mit Admin-Rechten auf Management → Attribute ..." ändern

@Zack-83 Zack-83 changed the title Update attributes.xml Attribute für FoDaKo-DFG hinzugefügt Jun 5, 2024
@Zack-83
Copy link
Member Author

Zack-83 commented Jun 5, 2024

@yvgrossmann Die Präfixänderungen sind unproblematisch, oder?

@Zack-83
Copy link
Member Author

Zack-83 commented Jun 5, 2024

@jmfrenzel Stimmst du zu, dass diese Attribute würdig sind?

Copy link
Member

@jmfrenzel jmfrenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zack-83 this PR suggests to add new pieces of shared content to the community maintained resources. I recommend to store this new content in the shared folder.

@jmfrenzel
Copy link
Member

I'm ok with the cosmetic changes. Please submit them in a separate PR.

@Zack-83
Copy link
Member Author

Zack-83 commented Jun 5, 2024

@Zack-83 this PR suggests to add new pieces of shared content to the community maintained resources. I recommend to store this new content in the shared folder.

I agree that this is the general rule. The problem is that this content has the same prefix https://rdmorganiser.github.io/terms as the core RDMO content.
It was a mistake from the beginning, but it has been there for years and it is used by FoDaKo, a quite big user group. How do you suggest solving this knot?

@torsten-rathmann
Copy link
Collaborator

torsten-rathmann commented Jun 18, 2024

Thanks for extending the attribute list and for the hint that sensitive_data/personal_data/protection_concept/rights_management is missing in the documentation!

Unfortunately I couldn't test the new attributes so far but in the file attributes.xml I found the following missprint: "project/dataset/sensitive_data/personal_data/consent/how_obrained" instaead of "project/dataset/sensitive_data/personal_data/consent/how_obtained". Could we have a correction?

@Zack-83
Copy link
Member Author

Zack-83 commented Jun 19, 2024

I'm ok with the cosmetic changes. Please submit them in a separate PR.

Done 942651a

@Zack-83
Copy link
Member Author

Zack-83 commented Jun 19, 2024

Thanks for extending the attribute list and for the hint that sensitive_data/personal_data/protection_concept/rights_management is missing in the documentation!

Unfortunately I couldn't test the new attributes so far but in the file attributes.xml I found the following missprint: "project/dataset/sensitive_data/personal_data/consent/how_obrained" instaead of "project/dataset/sensitive_data/personal_data/consent/how_obtained". Could we have a correction?

I have corrected the missprint.
As requested by @jmfrenzel I moved the 9 new attributes to a new file: shared/fodako/attributes-FoDaKo-dfg.xml .
Please update the documentation accordingly.

@torsten-rathmann
Copy link
Collaborator

I have tested the new attribute file shared/fodako/attributes-FoDaKo-dfg.xml from scratch and didn't find any issues. Thanks for the good work!

The new doc files Documentation5.2.pdf and Documentation5.2.docx contain a conplete list of needed additional attributes and an import instruction for the new attribute file attributes-FoDaKo-dfg.xml.
@Zack-83 Zack-83 merged commit 7980972 into master-rdmo2.x Jun 25, 2024
1 check passed
@Zack-83 Zack-83 deleted the FoDaKo-Attribute branch June 25, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants