Check is_optional for progress bar (again)

rdmorganiser · Aug 22, 2023 · b8ec63e · b8ec63e
1 parent 8d6e826
commit b8ec63e
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/rdmo/projects/progress.py b/rdmo/projects/progress.py
@@ -57,8 +57,9 @@ def count_questions(parent_element, sets, conditions):
             element_conditions = set(condition.id for condition in element.conditions.all())
             if not element_conditions or element_conditions.intersection(conditions):
                 if isinstance(element, Question):
-                    attributes.append(element.attribute)
-                    count += 1
+                    if not element.is_optional:
+                        attributes.append(element.attribute)
+                        count += 1
                 else:
                     if element.attribute:
                         attributes.append(element.attribute)