-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disclaimer 1st partner #574
Conversation
Please invite also https://github.com/dmartinezmu0 , https://github.com/SebastienMarmin & https://github.com/dario-pilori as reviewers |
Hi @Zack-83, sorry, but I don't see why we need this notice to be hard coded. This should depend on the catalog and or the views. Maybe we need better means to change the help message from within the catalog. Maybe we should talk about changes like this in the software or the steering group before you start working on the PR. |
Very willingly. It was originally a request by @jmfrenzel |
I agree with @jochenklar. We should discuss rdmorganiser/rdmo-catalog#44 at the catalog level. |
The text you refer to does not belong to any catalog. Instead, it is provided from the RDMO software, with placeholders allowing to express "for each dataset", "for each funder", "for each partner". Only that way it can appear with the same wording in all pages of a catalogue. I will close this PR. Feel free to propose another solution :) |
This text appears on all pages with multiple tabs and warns about the necessity to create at least one partner / dataset / ... to be able to continue.
The text was translated into all 5 language and then consolidated with PO Editor, which arbitrarily also change the length of all lines.
Closes rdmorganiser/rdmo-catalog#44
For all: we replaced
with
in all languages (please check the corresponding file for your language, around around Line 3500).