Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disclaimer 1st partner #574

Closed
wants to merge 3 commits into from
Closed

Disclaimer 1st partner #574

wants to merge 3 commits into from

Conversation

Zack-83
Copy link
Member

@Zack-83 Zack-83 commented Jan 23, 2023

This text appears on all pages with multiple tabs and warns about the necessity to create at least one partner / dataset / ... to be able to continue.

The text was translated into all 5 language and then consolidated with PO Editor, which arbitrarily also change the length of all lines.

Closes rdmorganiser/rdmo-catalog#44

For all: we replaced

"Please fill in the form for each project partner. The different project partners will be referred to in following questions. You can add a new project partner using the green button. Once created, you can edit or delete project partners using the buttons in the top right corner of the tabs."

with

"Please fill in the form for each project partner. If no partners are involved in your project, create at least one "Partner" to enter the required information below. The different project partners will be referred to in following questions. You can add a new project partner using the green button. Once created, you can edit or delete project partners using the buttons in the top right corner of the tabs."

in all languages (please check the corresponding file for your language, around around Line 3500).

@Zack-83
Copy link
Member Author

Zack-83 commented Jan 23, 2023

@Zack-83 Zack-83 marked this pull request as ready for review January 23, 2023 11:45
@coveralls
Copy link

coveralls commented Jan 23, 2023

Coverage Status

Coverage: 90.429%. Remained the same when pulling 9a64fec on disclaimer-1st-partner into ef6e1f8 on master.

@jochenklar
Copy link
Member

jochenklar commented Jan 23, 2023

Hi @Zack-83, sorry, but I don't see why we need this notice to be hard coded. This should depend on the catalog and or the views. Maybe we need better means to change the help message from within the catalog.

Maybe we should talk about changes like this in the software or the steering group before you start working on the PR.

@Zack-83
Copy link
Member Author

Zack-83 commented Jan 24, 2023

Hi @Zack-83, sorry, but I don't see why we need this notice to be hard coded. This should depend on the catalog and or the views. Maybe we need better means to change the help message from within the catalog.

Maybe we should talk about changes like this in the software or the steering group before you start working on the PR.

Very willingly. It was originally a request by @jmfrenzel

@jmfrenzel
Copy link
Member

Hi @Zack-83, sorry, but I don't see why we need this notice to be hard coded. This should depend on the catalog and or the views. Maybe we need better means to change the help message from within the catalog.

I agree with @jochenklar. We should discuss rdmorganiser/rdmo-catalog#44 at the catalog level.

@Zack-83
Copy link
Member Author

Zack-83 commented Jan 26, 2023

The text you refer to does not belong to any catalog. Instead, it is provided from the RDMO software, with placeholders allowing to express "for each dataset", "for each funder", "for each partner". Only that way it can appear with the same wording in all pages of a catalogue.

image
image

I will close this PR. Feel free to propose another solution :)

@Zack-83 Zack-83 closed this Jan 26, 2023
@jochenklar jochenklar deleted the disclaimer-1st-partner branch August 19, 2023 07:38
@jochenklar jochenklar restored the disclaimer-1st-partner branch August 19, 2023 07:38
@jochenklar jochenklar deleted the disclaimer-1st-partner branch August 19, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query for project partners
4 participants