Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use major.minor.patch constraint for 0 major version dependencies #711

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

afuetterer
Copy link
Member

Proposed changes

This PR proposed the following changes:

  • pin the version constraints of python dependencies, whose major version is 0

Refs: #693 (comment)

@MyPyDavid MyPyDavid added this to the 2.0.0 milestone Sep 19, 2023
@jochenklar
Copy link
Member

Thanks, but why not ~=?

@afuetterer
Copy link
Member Author

I can switch to ~=, no problem.

@afuetterer afuetterer changed the title chore: pin exact version constraints for 0 major versions chore: use major.minor.patch constraint for 0 major version dependencies Sep 20, 2023
@afuetterer
Copy link
Member Author

django-libsass only has a 0.9 version, not 0.9.0.

@jochenklar jochenklar merged commit 02d00b8 into rdmorganiser:dev-2.0.0 Sep 21, 2023
13 checks passed
@afuetterer afuetterer deleted the version-constraints branch September 22, 2023 04:20
CalamityC pushed a commit to CalamityC/rdmo that referenced this pull request Nov 23, 2023
chore: use major.minor.patch constraint for 0 major version dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants