Allow skipping tenants when running patches #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
jhuizy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a draft PR, I'm hoping for some feedback over whether this will be useful, or potentially unsafe.
This PR adds the ability to restrict the tenants that patches are run against when using the gem in an multi tenant environment via the Apartment gem.
Usually the patches are run against all tenants, however if there is some dodgy data in only one tenant it might be useful to be able to temporarily run patches against a subset of tenants. While it's possible to do a runtime check in each individual patch, this way allows us to run against a subset of tenants without making any code modifications and will affect all pending patches.
The main cause for concern is that it means patches can become out of sync between different tenants, and that can be hard to fix. However, it's good to at least give the user a choice.