feat: added custom type for LogLevel #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is nice, as you pointed out, this requires Go 1.21, so technically it's a breaking change. Don't think we have any runtimes that don't support Go 1.21, but let's have a look first. |
|
Is this going to be merged? |
escarls
force-pushed
the
feat/add-slog-loglevel-support
branch
from
8271675 to
07ece39
Compare
|
I've rebased this against the latest changes to main. |
|
We should probably add the |
With this type you will get a slog.LogLevel from the variable and if the value is not recognized, it will just return slog.LevelInfo Update the go versions matrix to at least 1.21, as slog requires that version
escarls
force-pushed
the
feat/add-slog-loglevel-support
branch
from
07ece39 to
1cd2cc3
Compare
|
Sorry for the back and forth, I know that I was the one pointing you in this direction, but after thinking about it. It makes sense to add support for this in our internal logger package. Are you OK with that? |
|
Closing this, as I've moved the code to cloud/logger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this type you will get a slog.LogLevel from the variable and if the value is not recognized, it will just return slog.LevelInfo