Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error to warning and add suppressWarning support #366

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

exlame
Copy link

@exlame exlame commented Feb 5, 2020

  • console.error should not be used like this because it is hard to run tests with error logs. async-validator is using warnings and rc-form should reflect the same strategy.

  • Adding suppressWarning support as async-validator to remove warnings when needed in tests suites.

@exlame exlame changed the title Charnge error to waring and suppressWarning support Change error to warning and add suppressWarning support Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant