Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double onchange and render double number pointer in input when i… #275

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

405go
Copy link

@405go 405go commented Nov 6, 2020

repro steps:

  1. visit https://ant.design/components/input-number-cn/
  2. switch to Chinese input method
  3. selected any input and type full stop...then you can see it has double pointer.

…nput first render use chinese input method and input full stop
@vercel
Copy link

vercel bot commented Nov 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/input-number/ocwejydkv
✅ Preview: https://input-number-git-master.react-component.vercel.app

let value = e.target.value
.trim()
.replace(/。/g, '.')
.replace(/\.+/g, '.');

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

能合成一个吗

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i got it

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #275 (c583bda) into master (5d29b67) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #275   +/-   ##
=======================================
  Coverage   93.01%   93.01%           
=======================================
  Files           1        1           
  Lines         372      372           
  Branches      134      134           
=======================================
  Hits          346      346           
  Misses         26       26           
Impacted Files Coverage Δ
src/InputNumber.tsx 93.01% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d29b67...c583bda. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants