Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix popup flicker issue when inline menus have benn collased #664

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ohhoney1
Copy link

@ohhoney1 ohhoney1 commented Sep 26, 2023

很久的一个历史问题了,antd 官方和本仓库demo都可复现。解析 Submenu 里的 items 时,如果存在嵌套 Submenu ,就出现此问题,即存在第三层 menu 的样式问题。

Kapture 2023-09-26 at 11 02 42

解决方案:考虑在inline模式下非折叠时,不设置 motion 动画。

相关 issue :ant-design/pro-components#7607 (comment) ,这个gif 同样问题。

相关 pr:

  1. fix: Collapsed inline menu whit Three level submenu bug #410 ,这个pr是在折叠后,直接把 popup 内容销毁,同样可以实现。
  2. fix menu popuptrigger flicker #497 ,但是它是手动设置动画,依然解决不了上述问题。

@yoyo837
Copy link
Member

yoyo837 commented Sep 26, 2023

能用例覆盖到吗?

@ohhoney1
Copy link
Author

能用例覆盖到吗?

抱歉忘记重跑一次用例了。本地有个用例没过: #578 这个 pr 新增的用例。我再看看,是否再加条用例

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants