feat(circle,line): enable indeterminate mode #216
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 99.36% 99.41% +0.05%
==========================================
Files 6 8 +2
Lines 157 172 +15
Branches 49 52 +3
==========================================
+ Hits 156 171 +15
Misses 1 1 ☔ View full report in Codecov by Sentry. |
|
👍 |
|
Rebase please |
|
@yoyo837 Done 😄 |
|
code coverage is down. |
src/utils/getIndeterminateCircle.tsx
Outdated
| }; | ||
| } | ||
|
|
||
| const animationName = 'circle-indeterminate-animate'; |
There was a problem hiding this comment.
Do not hard code this. Follow id generation logic to dynamic create this.
There was a problem hiding this comment.
@zombieJ
Just added could you check please, and one more thing is when we are using useId hook inside Line component it performs another render which changes the transition-duration like in Circle, so that's why i updated the snapshot.
arfter this change i tested on demo and i see no impacts.
|
Hi, will this be merged anytime soon? |
|
This is an enhancement for the request #84 it enables the indeterminate mode when the user does not define the percent property for both components circle and line.