-
Notifications
You must be signed in to change notification settings - Fork 80
chore: migrate to @rc-component namespace #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Walkthrough此次变更主要集中于两个配置文件。 Changes
Sequence Diagram(s)sequenceDiagram
participant 开发者 as Developer
participant 终端 as Terminal
participant 编译器 as Compiler
participant 发布工具 as "rc-np"
开发者->>终端: 执行 npm run compile
终端->>编译器: 发起编译任务
编译器-->>终端: 编译完成
终端->>发布工具: 执行 rc-np 发布命令
发布工具-->>终端: 发布完成
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
docs/examples/simple.tsxOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct. The config "prettier" was referenced from the config file in "/.eslintrc.js". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. tests/index.spec.jsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct. The config "prettier" was referenced from the config file in "/.eslintrc.js". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. src/index.tsxOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct. The config "prettier" was referenced from the config file in "/.eslintrc.js". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (6)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@babel/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
tsconfig.json (1)
18-20
: 新增路径映射 "@rc-component/switch"
新增的路径映射允许 TypeScript 将模块 "@rc-component/switch" 正确解析到 "src/" 目录。建议确认是否需要同时保留旧的 "rc-switch" 映射以确保向后兼容性,或在文档中标明迁移说明以避免混淆。package.json (1)
3-3
: 版本号更新提醒
版本号已更新为 "1.0.0"。如果这是一次重大重构或迁移,请在发布说明中详细说明变更内容。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
package.json
(3 hunks)tsconfig.json
(1 hunks)
🔇 Additional comments (4)
tsconfig.json (1)
17-17
: 确认路径映射 "@@/*" 的配置用途
该配置用于解析 dumi 生成的临时文件路径,请确认此映射在项目中是必须的,且文档中有相应说明。package.json (3)
2-2
: 更新包名称至新命名空间
包名称已更改为 "@rc-component/switch",符合迁移到 scoped package 的要求。请确保代码库内所有引用更新为新名称。
35-35
: 调整预发布脚本命令
将 prepublishOnly 脚本从原来的 "npm run compile && np --yolo --no-publish" 修改为 "npm run compile && rc-np",请确认 rc-np 工具功能符合预期发布流程,并更新相应的文档说明。
51-51
: 升级 "@rc-component/father-plugin" 依赖版本
将 "@rc-component/father-plugin" 从 "^1.0.0" 升级至 "^2.0.0"。建议验证新版本与现有构建流程的兼容性,并更新开发文档中的说明。
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 57 34 -23
Branches 11 8 -3
=========================================
- Hits 57 34 -23 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit