Fix compatibility issue for useMediaQuery #1663
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an asymmetric compatibility issue in
useMediaQuerywhere theaddEventListenercompatibility check was removed during subscription but still present during unsubscription, causing errors in older Safari versions.The recent commit 4880540 removed the
addEventListener/addListenerfallback logic increateQueryEntrybut kept it inqueryUnsubscribe, creating an inconsistency. This causes issues in Safari versions that don't supportaddEventListeneron MediaQueryList (Safari < 14).Changes
addEventListener/addListenercompatibility check increateQueryEntryto match the unsubscription logic inqueryUnsubscribeProblem
In older Safari versions,
MediaQueryListonly supports the deprecatedaddListener/removeListenermethods. The code was:addEventListenerunconditionally when subscribing (line 20)removeEventListener/removeListenerwhen unsubscribing (lines 52-56)This mismatch meant that in older Safari:
addEventListeneraddListenerremoveListeneron a listener that was never added