fix: Proposed fix for adding useWebKit support to getFromResponse/set… #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #72 useWebKit option on setFromResponse/getFromResponse
Test Plan
setFromResponse is working for me in live code, getFromResponse is untested.
Apologies, this is a draft PR I have no test plan.
What's required for testing (prerequisites)?
An url that produces cookies for getFromResponse
What are the steps to reproduce (after prerequisites)?
Check to see if getFromResponse successfully sets cookies in WKHTTPCookieStore.
Compatibility
Checklist
setFromResponse is tested in the wild, but getFromResponse is not, so no X in that box.
There is no CHANGELOG.md.
README.md
CHANGELOG.md
example/App.js
)