Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Proposed fix for adding useWebKit support to getFromResponse/set… #74

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Loxrie
Copy link

@Loxrie Loxrie commented Aug 17, 2020

Proposed fix for #72 useWebKit option on setFromResponse/getFromResponse

  • Should resolve issues with getFromResponse/setFromResponse not supporting WK cookie store.
  • Should not interfere with current calls to those methods by stubbing useWebKit as optional in index.js

Test Plan

setFromResponse is working for me in live code, getFromResponse is untested.

Apologies, this is a draft PR I have no test plan.

What's required for testing (prerequisites)?

An url that produces cookies for getFromResponse

What are the steps to reproduce (after prerequisites)?

Check to see if getFromResponse successfully sets cookies in WKHTTPCookieStore.

Compatibility

OS Implemented
iOS
Android

Checklist

setFromResponse is tested in the wild, but getFromResponse is not, so no X in that box.
There is no CHANGELOG.md.

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • [X ] I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@safaiyeh
Copy link
Member

Appreciate this @Loxrie I'll check this out soon

@tdoran
Copy link

tdoran commented Oct 1, 2020

Is there any update on whether/when this might be merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants