Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accentColor props for iOS datetimepicker (#20) #584

Merged

Conversation

simonnagl
Copy link
Contributor

Summary

This adds prop accentColor for iOS.
This relates to #20.

Test Plan

What's required for testing (prerequisites)?

Testing can be done with the example app. I added another input (accentColor) which can be used for testing.

What are the steps to reproduce (after prerequisites)?

Select display to compact or inline.
Enter a color value (i.e. #f00) into the accentColor field.
Check if picker appearance changes.

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

e2e test can not check color changes.

@peteratdivvy
Copy link

Would absolutely love for this to land. We really need a way to set the tintColor for the calendar.

Simon Nagl added 4 commits March 18, 2022 08:27
Scroll to bottom when rendering a date picker.
Ensure the date picker is shown.
Label Time Picker is used two times in dependency Tree.
Find element by type.
Copy link
Member

@vonovak vonovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the PR!

it's looking good, we just need to get the e2e tests green. Let me know if you want to have a look or I can do it too 👍

example/App.js Outdated Show resolved Hide resolved
example/e2e/utils/matchers.js Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@simonnagl simonnagl requested a review from vonovak March 21, 2022 11:36
README.md Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
simonnagl and others added 3 commits March 22, 2022 14:41
@simonnagl simonnagl requested a review from vonovak March 22, 2022 14:06
@vonovak vonovak enabled auto-merge (squash) March 22, 2022 14:16
@vonovak vonovak merged commit dcda13c into react-native-datetimepicker:master Mar 22, 2022
@vonovak
Copy link
Member

vonovak commented Mar 22, 2022

thanks a lot for the PR @simonnagl!

@vonovak
Copy link
Member

vonovak commented Mar 22, 2022

Please let me know if you'd like to get more involved with the project and I can add you to the repo 🙂

vonovak pushed a commit that referenced this pull request Mar 22, 2022
# [6.1.0](v6.0.2...v6.1.0) (2022-03-22)

### Features

* add accentColor prop for iOS ([#584](#584)) ([dcda13c](dcda13c)), closes [#20](#20)
@vonovak
Copy link
Member

vonovak commented Mar 22, 2022

🎉 This issue has been resolved in version 6.1.0 🎉

If this package helps you, consider sponsoring us! 🚀

@simonnagl
Copy link
Contributor Author

@vonovak Thank you a lot for maintaining this repo! And for the quick an gentle code review.

I may create further pull requests if needed personally. I likely will not work on the project on a open issue basis.

@simonnagl simonnagl deleted the feat/ios-accent-color branch March 22, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants