-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accentColor props for iOS datetimepicker (#20) #584
Add accentColor props for iOS datetimepicker (#20) #584
Conversation
Would absolutely love for this to land. We really need a way to set the tintColor for the calendar. |
Scroll to bottom when rendering a date picker. Ensure the date picker is shown.
Label Time Picker is used two times in dependency Tree. Find element by type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the PR!
it's looking good, we just need to get the e2e tests green. Let me know if you want to have a look or I can do it too 👍
Co-authored-by: Vojtech Novak <[email protected]>
Co-authored-by: Vojtech Novak <[email protected]>
Co-authored-by: Vojtech Novak <[email protected]>
thanks a lot for the PR @simonnagl! |
Please let me know if you'd like to get more involved with the project and I can add you to the repo 🙂 |
🎉 This issue has been resolved in version 6.1.0 🎉 If this package helps you, consider sponsoring us! 🚀 |
@vonovak Thank you a lot for maintaining this repo! And for the quick an gentle code review. I may create further pull requests if needed personally. I likely will not work on the project on a open issue basis. |
Summary
This adds prop accentColor for iOS.
This relates to #20.
Test Plan
What's required for testing (prerequisites)?
Testing can be done with the example app. I added another input (accentColor) which can be used for testing.
What are the steps to reproduce (after prerequisites)?
Select display to compact or inline.
Enter a color value (i.e.
#f00
) into theaccentColor
field.Check if picker appearance changes.
Compatibility
Checklist
README.md
example/App.js
)e2e test can not check color changes.