Material 3 pickers #952
Open
Material 3 pickers #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android Studio recommended these settings for supporting Kotlin in the project.
sidorchukandrew
force-pushed
the
material-3-pickers
branch
3 times, most recently
from
4f58cb1 to
22f3d0e
Compare
sidorchukandrew
force-pushed
the
material-3-pickers
branch
5 times, most recently
from
432884f to
ac33d0d
Compare
The new Material pickers will utilize these utilities as well.
sidorchukandrew
force-pushed
the
material-3-pickers
branch
4 times, most recently
from
5db9b03 to
55767b5
Compare
The pickers will allow the user to set a title for the dialog and specify if the initial input mode should be a text input or calendar/clock.
This also adds a utility function to RNDate to get the date in milliseconds.
sidorchukandrew
force-pushed
the
material-3-pickers
branch
2 times, most recently
from
e8a96a6 to
89dfccb
Compare
If the `design` is "material", then use the Material modules. Otherwise, use the default modules.
The tests were trying to access the native modules. These dummy files will make sure the tests don't try accessing the real implementations that end with `.android.js`.
Since there are multiple "default" options on the screen now, I've specified to tap the first one. I also had to make sure to scroll the screen before tapping the show picker button.
sidorchukandrew
force-pushed
the
material-3-pickers
branch
from
89dfccb to
2166b18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Material 3 date and time pickers for Android. Material 3 has been out for some time now and these new pickers would provide developers with more modern interfaces for their apps.
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdexample/App.js)TODO
I'm not sure how many of these need to be implemented to merge this PR.
firstDayOfWeek- [ ] Better theming support- [ ] Custom date validations- [ ] Expo plugin support