navigation.goBack(null) and fix SearchBar cancelButtonText #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangumer
commented
Oct 22, 2019
•
alangumer
commented
- Add null parameter, If null parameter is not present it won't go back when the Search Screen is a part of a top-level Navigator.
- Fix SearchBar cancelButtonText.
- Fix HeaderBackButton import
Add null parameter, If null parameter is not present it won't go back when the Search Screen is a part of a top-level Navigator.
alangumer
changed the title
HeaderBackButton has been moved to react-navigation-stack
brentvatne
requested changes
Feb 19, 2020
src/SearchBar.ios.js
Outdated
| @@ -178,7 +178,7 @@ export default class SearchBar extends React.PureComponent { | |||
| if (this.props.onCancelPress) { | |||
| this.props.onCancelPress(this.props.navigation.goBack); | |||
| } else { | |||
| this.props.navigation.goBack(); | |||
There was a problem hiding this comment.
i think we should probably just let the user override it with onCancelPress rather than default to goBack(null) here
There was a problem hiding this comment.
reverted goBack(null) to goBack().
|
i think at this point this library needs to be updated for react-navigation v5 now :) |
|
@brentvatne yeah :), I'm planning to do that next week. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.