feat: add full ESM support #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquense
reviewed
Jun 22, 2025
jquense
reviewed
Jun 22, 2025
kyletsang
force-pushed
the
import-extensions
branch
from
7cfc48e to
375d67a
Compare
kyletsang
commented
Jun 24, 2025
| import preventOverflow from '@popperjs/core/lib/modifiers/preventOverflow'; | ||
| import { placements } from '@popperjs/core/lib/enums'; | ||
| import { popperGenerator } from '@popperjs/core/lib/popper-base'; | ||
| // Since tsconfig is set for nodenext, these imports are resolving with a { default: ... } object, which |
There was a problem hiding this comment.
Unsure if there's a better way to handle this? Can be cleaned up when moving to floating UI?
jquense
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to modernize the codebase by adopting ES module syntax and improving type imports for better TypeScript support. Additionally, it updates dependencies and adjusts configurations to align with these changes.
ES Module Migration:
.babelrc.js: Changed from CommonJSmodule.exportsto ES moduleexport default.package.json: Updated thetypefield tomoduleand adjusted themainentry point tolib/index.js.TypeScript Enhancements:
src/(e.g.,Dropdown.tsx,DropdownMenu.tsx,Modal.tsx): Updated type imports to usetypekeyword for improved TypeScript clarity and performance. Added.jsextensions to local module imports for ES module compatibility. [1] [2] [3] [4]Dependency Updates:
package.json: Updateddom-helpersdependency from version^5.2.0to^6.0.1.Configuration Adjustments:
eslint.config.mjs: Disabled thereact/prop-typesrule, aligning with the project's focus on TypeScript for type checking. [1] [2]Code Cleanup:
src/Modal.tsx: Removed unnecessary ESLint disable comment forreact/prop-types, as this rule is now disabled globally in the ESLint configuration.