TypeScript Convertion - WIP #150
Open
+6,352
−4,241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
any plan to change the class components to functional one ? @pmm26 |
Not really while it would be nice to have them all on Functional Components. Class components still work and do the job. Time spent vs Benefits is just not worth it at the moment for me, converting ComponentShouldUpdate ... is not that straight forward. |
|
@pmm26 I will be creating a beta version of this release. Please let me know shall I do it or not? |
|
Code Climate has analyzed commit b2ad54c and detected 138 issues on this pull request. Here's the issue category breakdown:
Note: there are 4 critical issues. View more on Code Climate. |
* next15: Sutff # Conflicts: # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Files that still have typecript issues: - I hope to get these fixed.
Updating items & DND is not tested and may have issues related to the change from date string to Dayjs.
If these issues can be identified I can help fix them but I don't have a lot of time.
Might be better to make a new branch to put this on if you think these changes are usefull.