Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding react-split-pane package and prepublish.sh #14

Merged
merged 2 commits into from
Oct 11, 2016
Merged

Adding react-split-pane package and prepublish.sh #14

merged 2 commits into from
Oct 11, 2016

Conversation

xRahul
Copy link
Contributor

@xRahul xRahul commented Oct 11, 2016

Related issue- #13
Added react-split-pane package from npm and removed the SplitPane component.

The code is also transpiled into dist folder.

To transpile the code, there was a requirement to run the prepublish.cmd script which automatically gets called during npm i

As that script only runs on windows systems, I've created a prepublish.sh file that can be used on mac/linux systems.

just need to make the following changes in package.json

-     "prepublish": ".scripts\\prepublish.cmd",
+     "prepublish": ".scripts/prepublish.sh",

removed the components for SplitPane and used the package
react-split-pane instead
Transpiled the code, and added prepublish.sh file
@usulpro
Copy link
Member

usulpro commented Oct 11, 2016

Thank you! First looks Ok.
Could you divide it into two PRs?
For second please check this original scripts and storybook-eol/react-cdk#6
so we better to have a universal solution. I'll appreciate if you make PR for this.

@xRahul
Copy link
Contributor Author

xRahul commented Oct 11, 2016

@usulpro I'm not much good with either of the .cmd or the .sh scripts. You can create a new issue for this which someone else can take on.

@usulpro
Copy link
Member

usulpro commented Oct 11, 2016

Sure! here it is #15
Anyway i'll merge it. thank you!

@usulpro usulpro merged commit 56170b3 into react-theming:master Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants