Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the repo, and new docs styling #29

Merged
merged 29 commits into from
Feb 17, 2024

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Jan 21, 2024

  • Refactors the repo structure to match reactpy-django
  • Update styling/formatting of the docs

This PR is mostly folder and CI workflow reorganization. The the docs still need an overhaul, and the source code needs refactoring to match react-router better.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Archmonger Archmonger marked this pull request as ready for review January 21, 2024 09:30
@Archmonger
Copy link
Contributor Author

@rmorshea Can you provide me merge permissions for this repo?

@Archmonger
Copy link
Contributor Author

@rmorshea I still don't have permissions to change required workflows.

@rmorshea
Copy link
Contributor

Looks like we're missing coverage enforcement from the tests.

@Archmonger
Copy link
Contributor Author

Will work on that now. On a related note, I've been debating whether we should drop black and instead rely strictly on the ruff formatter.

@Archmonger
Copy link
Contributor Author

Will merge this one with the coverage fixes. Let me know your opinion on pulling out black from our repos and relying solely on ruff.

@Archmonger Archmonger merged commit 0f4dea2 into reactive-python:main Feb 17, 2024
8 checks passed
@Archmonger Archmonger deleted the refactor-and-new-docs branch February 17, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants