Add documentation explaining how to use ReactiveUserControl in XAML #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n UWP projects and the WPF designer window
glennawatson
requested changes
Dec 11, 2018
| @@ -36,6 +36,33 @@ namespace ReactiveUI | |||
| /// ]]> | |||
| /// </code> | |||
| /// </para> | |||
| /// <para> | |||
| /// Note that UWP projects do not support the <c>TypeArguments</c> attribute. The XAML designer window in WPF projects also do not | |||
| /// support generic types. To use <see cref="ReactiveUserControl{TViewModel}"/> in XAML documents you need to create a base class | |||
There was a problem hiding this comment.
You don't have to do it this way. The xaml designer is do fragile I gave up on it years ago. So might be worth saying more like "to use the base class"
There was a problem hiding this comment.
It doesn't compile in an UWP (it does in WPF) project when you just use ReactiveUserControl. The xaml designer is an extra for me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation explaining how to use ReactiveUserControl in XAML in UWP projects and the WPF designer window.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update
What is the current behavior? (You can also link to an open issue here)
#1853