-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simpleinjector reimplementation #631
Simpleinjector reimplementation #631
Conversation
Sync with Splat repo
There's some failing unit tests unfortunately. You can click the build action to see the details. Thanks for the work so far |
I made a little mistake and i pushed invalid code (sorry). For now, everything should be okay but the build is failing - and I'm not sure why or how to fix it. It's all building on my machine and it passes all the tests successfully. |
The latest is a build error that is on and off we've seen before with Nerdbank git versioning tool we use. I might make a report to the library author. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, few threading tweaks and some bits around the read me just to expand\ clarify knowledge
closes #597 |
cleaned up. documented weakness in dupe registrations |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
Currently there's no way to use SimpleInjector in projects.
What is the new behavior?
SimpleInjector works well with Splat & ReactiveUI initializations.
What might this PR break?
Probably nothing.
Please check if the PR fulfills these requirements
Other information:
I've tested the solution with my very small project based on WPF - all works okay. Anyway, I've no clue about performance of the solution (probably most important thing on mobile platforms).