Clarify createPortal usage #845
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunofreiberg
changed the title
|
Deploy preview for reactjs ready! Built with commit 2c07ff9 |
|
I don't think this is technically accurate. You could call it in a lifecycle, then put the result into state and then use that in render. Not necessarily useful but possible. The important part is that it doesn't do anything imperatively and it just produces an object similar to a React element. The portal only "works" when this object is included in the rendered tree. |
|
What about something like this? I don't really like the word "work/working" since it's quite ambiguous and tried to avoid it. |
BetterZxx
pushed a commit
to BetterZxx/react.dev
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#840. I think this clarification makes more sense as a note.