Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: useForEach Hook #262

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

pschiffmann
Copy link

In this RFC, I propose adding the useForEach Hook to React.

View RFC

Summary

The useForEach Hook provides a sane mechanism for calling React Hooks inside loops.

Basic example

The useForEach(keys, callback) Hook calls callback once for each element in the keys iterable.
The callback function is allowed to call Hooks, as if it was at the top level of the component.

import { useEffect, useForEach, useMemo, useState } from "react";

function MyComponent({ keys }) {
  const results = useForEach(keys, (key) => {
    const [state, setState] = useState(/* ... */);
    useEffect(/* ... */);
    return useMemo(/* ... */);
  });
  // ...
}

@facebook-github-bot
Copy link
Collaborator

Hi @pschiffmann!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@pschiffmann
Copy link
Author

After writing the RFC, I had the idea to check for similar RFCs not just the open issues, but also the closed ones. (Genius, I know 😅) And I found #158 that seems to address the very same problem, just with a slightly different API.

I can see that #158 was closed because:

It is, in our opinion, a bit too complicated and advanced to be used widely, and not worth it if it's used rarely.

I know this is just a single data point, but at least for me and the type of apps I'm working on, this is a frequent real-world use case. So I'd be really happy if you could give this a second thought, or at least leave it open to see if it gathers more community interest.

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants