-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: useForEach
Hook
#262
base: main
Are you sure you want to change the base?
RFC: useForEach
Hook
#262
Conversation
Hi @pschiffmann! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
After writing the RFC, I had the idea to check for similar RFCs not just the open issues, but also the closed ones. (Genius, I know 😅) And I found #158 that seems to address the very same problem, just with a slightly different API. I can see that #158 was closed because:
I know this is just a single data point, but at least for me and the type of apps I'm working on, this is a frequent real-world use case. So I'd be really happy if you could give this a second thought, or at least leave it open to see if it gathers more community interest. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
In this RFC, I propose adding the
useForEach
Hook to React.View RFC
Summary
The
useForEach
Hook provides a sane mechanism for calling React Hooks inside loops.Basic example
The
useForEach(keys, callback)
Hook callscallback
once for each element in thekeys
iterable.The
callback
function is allowed to call Hooks, as if it was at the top level of the component.