Create Azure App And Configure Jvm Size #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@violetagg , or @chemicL , can someone of you please review this PR ? |
violetagg
approved these changes
Mar 6, 2024
|
@violetagg , thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the deploy-to-azure workflow for the projectreactor site Azure spring app. Previously, it was assumed that the azure spring app was manually created before using this workflow. Now, if the app doesn't exist, this PR creates it and ensures it has at least 2 GB of memory to run.
Additionally, the spring app is now deployed with Java 11, like our old CF servers. The JVM memory is configured to 1 GB as before. However, due to memory requirements, the spring app memory is set to 2 GB. Setting the JVM to 1 GB actually needs more memory. If we set the application max memory size to 1 GB, it leads to a deployment error.